Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump policy_max argument of cmake_minimum_required to 3.28 #980

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

traversaro
Copy link
Member

I recently had problem in compiling icub-main in a conda environment with Python 3.10 installed while the system (Ubuntu 24.04) had Python 3.12 installed. This happened as the old (pre-3.15) behaviour of CMake was to always find the most recent Python version, instead of getting the highest in the path (see https://cmake.org/cmake/help/latest/policy/CMP0094.html).

The problem can be solved without raising the minimum required CMake by setting the CMP0094 policy to NEW, but I think it was good idea to directly raise the policy_max (i.e. the version used for the policies of CMake) argument of cmake_minimum_required to 3.28.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pattacini pattacini merged commit 2c799b7 into robotology:master Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants